Links to latest topic post in email, require user login

Discussion about the website and the forum goes here.
Post Reply
User avatar
B-$hep
Immortal
Posts: 531
Joined: 24 Apr 2009, 21:43
GH nick: B-Shep
Location: Estonia - Finland

Links to latest topic post in email, require user login

Post by B-$hep » 29 Mar 2011, 23:01

At work i often read my emails with mobile, and when GTAMP forum sends me notification about new post in my (or any) thread and displays direct link to the thread and last post,and when i try to open the link, it sends me to some error page and requires to log in.

This makes no sense. Because the forum is public, all threads are public and when im trying to access last post in some thread quickly, it just doesn't let me.

Why i have to log in to see latest new post?
It doesn't make any sense.


Sektor, can you please fix it?
Always wear safety glasses while programming.

User avatar
Sektor
Boss
Boss
Posts: 1369
Joined: 04 Mar 2008, 06:51
GH nick: Sektor
Location: GTAMP.com
Contact:

Re: Links to latest topic post in email, require user login

Post by Sektor » 30 Mar 2011, 01:08

Yes that is pretty stupid. The second link in the email is a a link to the forum that doesn't require login, so you can click that instead but that will take you to the first page of the thread.

The first link requires logging in since it needs to know when you last visited.

A link to the actual post that was updated or the last page would be useful.

User avatar
B-$hep
Immortal
Posts: 531
Joined: 24 Apr 2009, 21:43
GH nick: B-Shep
Location: Estonia - Finland

Re: Links to latest topic post in email, require user login

Post by B-$hep » 30 Mar 2011, 02:06

Yes, maybe there is some patch or something, that would allow it.
Or you could DIY.

Actually i can go to last page but because my phone is so old and with small screen (with very poor web support) it cant even display user/psw boxes. And i have to click many many times, until it gets to last post.
ca
But it n display gmail user/psw boxes and even logs in lol.

It's samsung sgh-x500.
Time to upgrade soon.
Always wear safety glasses while programming.

User avatar
Sektor
Boss
Boss
Posts: 1369
Joined: 04 Mar 2008, 06:51
GH nick: Sektor
Location: GTAMP.com
Contact:

Re: Links to latest topic post in email, require user login

Post by Sektor » 30 Mar 2011, 02:58

I edited /forum/includes/functions_posting.php

I changed U_TOPIC from "/viewtopic.$phpEx?f=$forum_id&t=$topic_id" to "/viewtopic.$phpEx?p=$post_id#$post_id".

I left U_NEWEST_POST as "/viewtopic.$phpEx?f=$forum_id&t=$topic_id&p=$post_id&e=$post_id". I'll edit the descriptions to make it clear that this one needs you to login.

User avatar
B-$hep
Immortal
Posts: 531
Joined: 24 Apr 2009, 21:43
GH nick: B-Shep
Location: Estonia - Finland

Re: Links to latest topic post in email, require user login

Post by B-$hep » 26 Apr 2011, 21:43

Thank you Sektor. I got a reply in ScrPad topic,decided to try the link in email and it sent me almost to the end of the topic.

Good enough.
Always wear safety glasses while programming.

User avatar
Sektor
Boss
Boss
Posts: 1369
Joined: 04 Mar 2008, 06:51
GH nick: Sektor
Location: GTAMP.com
Contact:

Re: Links to latest topic post in email, require user login

Post by Sektor » 26 Apr 2011, 21:50

It still needs improvements and now it gives you two links to the exact same URL. You also won't get any new emails until you login (it's a feature but not one eveyone wants).

User avatar
B-$hep
Immortal
Posts: 531
Joined: 24 Apr 2009, 21:43
GH nick: B-Shep
Location: Estonia - Finland

Re: Links to latest topic post in email, require user login

Post by B-$hep » 26 Apr 2011, 21:58

Actually there are many links. I clicked second one and it took me to last page..
If you want to view the topic, click the following link:

http://gtamp.com/forum/viewtopic.php?p=4108#4108

Tried on mobile:
Always wear safety glasses while programming.

Post Reply